Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Small data-class refactor. #51

Merged
merged 2 commits into from
Feb 29, 2024
Merged

Small data-class refactor. #51

merged 2 commits into from
Feb 29, 2024

Conversation

astronomerritt
Copy link
Collaborator

Fixes #39.

I have refactored the data-classes a bit. I did not make as many changes as anticipated - I have mostly just moved work out of init and consolidated the get_from_table methods into a single method. It's more testable now.

I have also added docstrings in the numpydoc format.

Review Checklist for Source Code Changes

  • Does pip install still work?
  • Have you written a unit test for any new functions?
  • Do all the units tests run successfully?
  • Does adler run successfully on a test set of input files/databases?
  • Have you used black on the files you have updated to confirm python programming style guide enforcement?

@astronomerritt astronomerritt merged commit c605b7b into main Feb 29, 2024
6 checks passed
@astronomerritt astronomerritt deleted the dataclass_refactor branch March 5, 2024 11:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Changes to data classes
2 participants